Use base page y-overflow and make the nav, tab nav and table headers sticky #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unlighthouse canceled.
|
|
Thanks, @NathanBeddoeWebDev! I think I'll be off Unlighthouse for a few days but when I'm back working on it I'll be looking at the UI and will likely pull this PR in. I'd like to add some sort of pagination with this change as well as well as some other minor improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the overflow from the main grid, and instead makes the whole base of the page scrollable. The main nav, tabs and table header have been positioned as sticky so they will still follow the user down the page as they scroll.
This leads to a more consistent user experience with other sites.
Also confirmed that GoFullPage screenshots the full page now.
Linked Issues
fix #76