-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using unlighthouse-ci --output-path= <path>
removes the target directory.
#200
Comments
Thanks for the issue, will jump on it when I have a chance. PRs welcome otherwise :) |
also running just |
Have pushed up a fix for this, it would no longer attempt to delete the output path, only the generated runtime folder which has a path as
The CI will always reset the cache, I'd suggest just using |
Describe the bug
Using
unlighthouse-ci --output-path= <path>
removes the target directory.Specifying a path can have catastrophic effects if the command is run with the wrong permissions or on an unprotected directory.
Reproduction
unlighthouse-ci --output-path= <an_unprotected_path_with_stuff_you_want_to_keep>
System / Nuxt Info
Resolution
Prevent this behavior by only attempting to remove
reports/
if it exists and clearly document CI option behavior.The text was updated successfully, but these errors were encountered: