Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native 'base64url' buffer encoding #37

Open
kanongil opened this issue Apr 15, 2021 · 0 comments · May be fixed by #43
Open

Use native 'base64url' buffer encoding #37

kanongil opened this issue Apr 15, 2021 · 0 comments · May be fixed by #43
Labels
feature New functionality or improvement

Comments

@kanongil
Copy link

Support plan

  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: v15.14.0
  • module version: 5.0.0
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): standalone
  • any other relevant information:

What problem are you trying to solve?

Enabled more efficient B64.base64urlEncode() encoding by using the Buffer 'base64url' encoding that has been introduced in v15.7.0.

The feature can be detected by calling Buffer.isEncoding('base64url').

Do you have a new or modified API suggestion to solve the problem?

No API changes required.
@kanongil kanongil added the feature New functionality or improvement label Apr 15, 2021
@geek geek linked a pull request Jul 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New functionality or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use node base64url option geek/b64
1 participant
@kanongil