Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IG selection phrase should use polyglot interpolation #101

Closed
dotasek opened this issue Oct 18, 2022 · 0 comments
Closed

IG selection phrase should use polyglot interpolation #101

dotasek opened this issue Oct 18, 2022 · 0 comments
Assignees
@Hankych
Labels
enhancement New feature or request

Comments

@dotasek
Copy link
Collaborator

dotasek commented Oct 18, 2022

options_ig_selected could be a polyglot interpolation instead of a concatenation within kotlin.

org.hl7.fhir.validator-wrapper/src/jsMain/kotlin/ui/components/options/IgSelector.kt

Line 140 in 2d38521

+ (props.polyglot.t("options_ig_selected") + " (${props.selectedIgSet.size})" + if (props.selectedIgSet.isEmpty()) { "" } else { ":"})

This is a minor change to a best practice so future devs can see an example interpolation in the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hankych Hankych

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create stub of test for BrowserLanguage hapifhir/org.hl7.fhir.validator-wrapper
2 participants
@dotasek @Hankych