Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash on bad files present in IG, ignore & warn instead #55

Merged

Conversation

vadi2
Copy link
Contributor

@vadi2 vadi2 commented Jun 26, 2019

If an invalid file is present in the context folder, the validation will fail. This means that you have to get all your files to be perfect before you can validate the one in question - seems harsh, irrelevant files should be ignored instead. This PR adds a warning instead, so the output now is:

+  .. load IG from /home/vadi/Desktop/mirjamstestproject/mirjamstestproject
 ..file: ObservationDefinition-example.xml - ignored due to error: Unknown resource type ObservationDefinition
 ..file: adam-everyman.json  .. validate [/home/vadi/Desktop/mirjamstestproject/mirjamstestproject/adam-everyman.json]
Terminology server: Check for supported code systems for https://www.alpha.alp/use-case

Fixes #54.

This is just about the #1 complaint in Hammer right now, Java validator giving errors on files that aren't the target of the validation (health-validator/Hammer#81)

@grahamegrieve grahamegrieve merged commit d7f071b into hapifhir:master Jul 3, 2019
@vadi2 vadi2 deleted the dont-choke-on-irrelevant-files branch July 3, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrelated resources in context directory break validation
2 participants