Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary functions return incorrect results #1659

Open
johngrimes opened this issue Jun 19, 2024 · 2 comments
Open

Boundary functions return incorrect results #1659

johngrimes opened this issue Jun 19, 2024 · 2 comments

Comments

@johngrimes
Copy link
Contributor

johngrimes commented Jun 19, 2024

It seems as though the spec has been updated with respect to the semantics of the boundary functions, but the implementations within this library have not been changed to reflect this.

Here is the specification for lowBoundary: https://build.fhir.org/ig/HL7/FHIRPath/#lowboundaryprecision-integer-decimal--date--datetime--time

The first example is:

1.587.lowBoundary(8) // 1.58700000

The result returned by the library:

Utilities.lowBoundaryForDecimal("1.587", 8)  // 1.58650000
@johngrimes
Copy link
Contributor Author

johngrimes commented Jun 20, 2024

I note that the FHIRPath page in the CI build of the FHIR spec seems to be different, I am a bit confused by this: https://build.fhir.org/fhirpath.html#fn-lowBoundary

@grahamegrieve
Copy link
Collaborator

I don't think that they're wrong, but see discussion here: https://chat.fhir.org/#narrow/stream/179266-fhirpath/topic/Boundary.20functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants