Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformsToProfile returns false even if the error is unrelated to profile conformance #1468

Closed
TahaAttari opened this issue Oct 23, 2023 · 1 comment

Comments

@TahaAttari
Copy link

TahaAttari commented Oct 23, 2023

boolean ok = true;
List<ValidationMessage> record = new ArrayList<>();
for (ValidationMessage v : valerrors) {
ok = ok && !v.getLevel().isError();
if (v.getLevel().isError() || v.isSlicingHint()) {
record.add(v);
}
}

conformsToProfile returns ok = false for any validation errors in the resource / element being checked, but should really only return false for profile conformance failure.

@grahamegrieve
Copy link
Collaborator

Any validation error is a failure against the profile. And I don't know if I can differentiate in any useful way. Further discussion if you think there's something that should be done here: https://chat.fhir.org/#narrow/stream/179177-conformance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants