Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent double port assignment within ApacheProxyStrategy #2869

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ZuSe
Copy link
Contributor

@ZuSe ZuSe commented Aug 6, 2021

Resolves: #2856

@ZuSe
Copy link
Contributor Author

ZuSe commented Aug 6, 2021

How can I retrigger that test? It failed coz of a 502.

@ZuSe
Copy link
Contributor Author

ZuSe commented Nov 18, 2021

PUSH

@jkiddo
Copy link
Contributor

jkiddo commented Feb 9, 2022

@jamesagnew / @tadgh community would appreciate if you could look at this

@jamesagnew
Copy link
Collaborator

I'm not sure I understand what's changing - Could a test be written to exercise the fix? Happy to merge with that in place.

@ZuSe
Copy link
Contributor Author

ZuSe commented Feb 16, 2022

Hi @jamesagnew it's explained in the original ticket that I linked.

hapifhir/hapi-fhir-jpaserver-starter#258

No idea how to write a test for it as I would need to make the whole test-suite run on a kubernetes cluster with respective load balancers / network service in place, right?

@jamesagnew
Copy link
Collaborator

A simple test that uses Mockito to mock the HttpServletRequest would be the best thing - You can use mockito to have the request supply the various possible input values then ensure that the return value is appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port is double reported when using Apache Strategy
3 participants