UnitTests in FhirResourceDaoR4ValidateTest are highly dependent

[TipzCM]

Running all the tests in FhirResourceDaoR4ValidateTest will result in the entire test suite passing.

However, running individual tests will result in those same tests failing.

testValidateWithFragmentCodeSystem_WithDirectBinding for instance, fails when run alone.

Including the following code at the beginning of the tests will cause it to pass, however:

String resource = loadResource("/r4/uscore/patient-resource-badcode.json");
IBaseResource parsedResource = myFhirCtx.newJsonParser().parseResource(resource);
try {
	myPatientDao.validate((Patient) parsedResource, null, resource, null, null, null, mySrd);
} catch (PreconditionFailedException e) {
}

Since this code is only doing validation, it's likely the underlying code is bugged, too. Ie, one does not expect calls to validate to be dependant on previous calls to validate.

Expected Results

• Tests should not be dependant on each other
• Calls to validate should not be dependant on previous calls to validate

As an aside, the underlying BaseJpaR4Test should be cleaned up to only have a single BeforeEach and a single AfterEach. Multiples are not advisable as they are run in alphabetical order one after another (combining all of the BeforeEach/AfterEach into one is advisable)