Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image tags mismatch with HAPI FHIR version #664

Open
gmej opened this issue Mar 19, 2024 · 1 comment
Open

Docker image tags mismatch with HAPI FHIR version #664

gmej opened this issue Mar 19, 2024 · 1 comment

Comments

@gmej
Copy link

gmej commented Mar 19, 2024

I have deployed with Helm, with the following config in values.yaml

image:
  registry: docker.io
  repository: hapiproject/hapi
  tag: "v7.0.2"
  pullPolicy: Always

But the /metadata endpoint reports being v7.0.0

{
    ...
    "software": {
        "name": "HAPI FHIR Server",
        "version": "7.0.0"
    }
    ...
}

Is this a problem on my side? Or maybe Docker images aren't correctly tagged? Building source (in version v7.0.2) in a new Docker Image does report the correct version "v7.0.2" in the /metadata endpoint

@chgl
Copy link
Contributor

chgl commented May 16, 2024

I deliberately proposed to be able to decouple image builds from releases in the repository back in #217. That being said, I agree that this can be confusing since usually a new image is only built and released when a new hapi fhir version is available.

So instead of building a new image only if a tag looking like image/vX.Y.Z is created, I wouldnt mind changing the workflow to build a new image on regular tags which correspond to the hapi fhir version (the downside of course being that hapi-fhir-jpaserver-starter specific changes have to happen in-sync with upstream releases in the https://github.com/hapifhir/hapi-fhir repo to keep the releases and tags consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants