Unintended requirement?

[jkiddo]

I haven't investigated why - but if the reindex job isn't registrered ahead of installing IG's then the installing fails.

hapi-fhir-jpaserver-starter/src/main/java/ca/uhn/fhir/jpa/starter/common/StarterJpaConfig.java

Line 199 in a06c0b9

jobDefinitionRegistry.addJobDefinitionIfNotRegistered(reindexJobParametersJobDefinition);

-is this intended?

[jamesagnew]

Just a guess, but probably it's trying to kick off a reindex job. I'd bet it doesn't fail if that setting is disabled.

We should probably just temporarily disable that setting even if it's already set when installing IGs.

[XcrigX]

I think I'm not following something, but doesn't it need to kick off a re-index job if the IG adds new search parameters?

[jamesagnew]

....probably.

i dunno, i've always kind of been of the opinion that reindex jobs should always be manually kicked off.. but obviously it's not ideal having search parameters installed that haven't yet been indexed.

[XcrigX]

Yeah, mostly agree.. I added a PR (since merged) last year so that existing IGs would not be re-installed specifically to avoid that auto-reindex occurring if the server is re-started with the IG loader settings still enabled. But making the reindex always manual makes sense too. It can be an unpleasant surprise to have a reindex job kick off on a server with lots of data.

[jkiddo]

Could a way forward be to explicitly have a config option to either enable or disable index jobs to run automatically? Problem then becomes to choose a sane default. If SearchParameters often pops up in installed IG's then it should be default, but I follow your arguments that it should usually be handled manually