New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is `inline_resource_storage_below_size` set to `4000` on purpose in `application.yml`? #496

Open

muhammad-levi opened this issue Feb 9, 2023 · 0 comments

Contributor

muhammad-levi commented Feb 9, 2023

hapi-fhir-jpaserver-starter/src/main/resources/application.yaml

Line 180 in 9847d82

inline_resource_storage_below_size: 4000

I am trying to add configurability of ResourceEncoding in the DaoConfig object, but because of this inline_resource_storage_below_size set to 4000 in the application.yml (and in my profile-specific yml that property is not set), making it to ignore the DaoConfig.ResourceEncodingEnum and use ResourceEncodingEnum.JSON when the posted resource size is below the threshold (4000).
https://github.com/hapifhir/hapi-fhir/blob/master/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java#L563

Should we comment inline_resource_storage_below_size in the application.yml?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment