Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to using multitenancy_enabled in application.yml #227

Closed
citizenrich opened this issue Apr 21, 2021 · 2 comments
Closed

Revert to using multitenancy_enabled in application.yml #227

citizenrich opened this issue Apr 21, 2021 · 2 comments

Comments

@citizenrich
Copy link

Hi folks. So, it seems a relatively recent PR changed the config to toggle multitenancy off/on. The way it is toggled on is to uncomment like so:

    partitioning:
#      allow_references_across_partitions: false
#      partitioning_include_in_search_hashes: false

See: #200

The issue, besides the above being unintutive, is that this doesn't work for environment variables (like the configs I've tried which do support env vars). I wonder if there is interest in reverting to the previous approach, which explicitly calls out the config, with multitenancy_enabled: true. IMHO this would be intuitive and can be changed in the environment. Thoughts?

@citizenrich
Copy link
Author

@jtheory

@citizenrich
Copy link
Author

So, for those looking for the setting, at least in v5.4.1, hapi.fhir.partitioning.enabled is seen by the config parser, even if it is not in application.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant