Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the output format is valid at the beginning #71

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sezanzeb
Copy link

@sezanzeb sezanzeb commented May 30, 2024

Waiting for this to complete, just to realize that the output format was missing, was a bit frustrating. This checks if a file-extension is valid right at the start.

Other minor changes:

  • there was duplicate (and slightly outdated) code in bin/voicefixer
  • the shebang was changed to #!/usr/bin/env python
  • the description of the modes was added to the argparse help
  • Print time it took for the restoration
  • Make bin executable

I think it's really great that you provided a docker setup for this.

@sezanzeb
Copy link
Author

sezanzeb commented May 30, 2024

I still need to test if using an input and output folder still works, but I have to leave now. Other than that, this is finished.

@sezanzeb sezanzeb marked this pull request as ready for review May 31, 2024 09:04
@sezanzeb
Copy link
Author

@haoheliu this is ready for review

@haoheliu
Copy link
Owner

Nice thanks for your effort! I will take a look on that! @sezanzeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants