Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor tests to filepath.Join instead of / #3

Merged
merged 1 commit into from
Apr 21, 2023
Merged

refactor tests to filepath.Join instead of / #3

merged 1 commit into from
Apr 21, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Apr 21, 2023 •
edited
Loading

This PR refactors benchmarks to use filepath.Join instead of manually constructed paths with /. Because dir + "/../demo/data/" is not working on OSes which have different path separators.

Also, handle err in os.Getwd.

@haoel haoel merged commit bf6cb5e into haoel:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoel haoel haoel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @haoel