You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hannobraun opened this issue
Jan 18, 2024
· 0 comments
Labels
topic: validationInfrastructure for checking various properties of objects, making sure they are valid.type: featureNew features and improvements to existing features
Shell defines a boundary within a 3-dimensional space. Solid defines a solid object, which is defined as a collection of shells. These shells might be completely distinct, forming multiple bodies of the solid, or they might be nested inside of each other, forming cavities within a body.
The shells themselves must not intersect, however. That would make the solid invalid. This is neither documented nor enforced right now. We need a validation check for that.
Implementation
The new validation check would go into validate::solid. There are already other validation check there, as well as numerous more in sibling modules, which can be used as a template for the new one.
Related Issues
There are a few related issues that are currently open:
Improve validation infrastructure #2157 is about a refactor of the validation infrastructure. If that were implemented first, it would change where the new validation check would go, and how specifically it would be implemented.
None of those issues are blockers for this one, but if work on them was ongoing by the time this issue is picked up, that would require coordination between the issues.
The text was updated successfully, but these errors were encountered:
topic: validationInfrastructure for checking various properties of objects, making sure they are valid.type: featureNew features and improvements to existing features
Current Situation
Shell
defines a boundary within a 3-dimensional space.Solid
defines a solid object, which is defined as a collection of shells. These shells might be completely distinct, forming multiple bodies of the solid, or they might be nested inside of each other, forming cavities within a body.The shells themselves must not intersect, however. That would make the solid invalid. This is neither documented nor enforced right now. We need a validation check for that.
Implementation
The new validation check would go into
validate::solid
. There are already other validation check there, as well as numerous more in sibling modules, which can be used as a template for the new one.Related Issues
There are a few related issues that are currently open:
None of those issues are blockers for this one, but if work on them was ongoing by the time this issue is picked up, that would require coordination between the issues.
The text was updated successfully, but these errors were encountered: