From c32c0d271060b5b832a6164255741b3958acd27a Mon Sep 17 00:00:00 2001 From: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com> Date: Fri, 22 Jul 2022 20:16:48 -0400 Subject: [PATCH] remove dead comment (#46132) #45993 fixed this bug, let's make the math effect-tests actually fail --- test/math.jl | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/test/math.jl b/test/math.jl index 9eb57ad1f22c3..02d8a8d1f8fca 100644 --- a/test/math.jl +++ b/test/math.jl @@ -1458,14 +1458,7 @@ for fn in (:sin, :cos, :tan, :log, :log2, :log10, :log1p, :exponent, :sqrt, :cbr for T in (Float32, Float64) f = getfield(@__MODULE__, fn) eff = Base.infer_effects(f, (T,)) - if Core.Compiler.is_foldable(eff) - @test true - else - # XXX only print bad effects – especially `[sin|cos|tan](::Float32)` are analyzed - # as non-foldable sometimes but non-deterministically somehow, we need to dig - # into what's leading to the bad analysis with Cthulhu on each platform - @warn "bad effects found for $f(::$T)" eff - end + @test Core.Compiler.is_foldable(eff) end end for T in (Float32, Float64)