Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorised SHA3 includes in non-vectorised code #939

Closed
franziskuskiefer opened this issue Apr 24, 2024 · 0 comments · Fixed by #940
Closed

Vectorised SHA3 includes in non-vectorised code #939

franziskuskiefer opened this issue Apr 24, 2024 · 0 comments · Fixed by #940
Labels
bug

Comments

@franziskuskiefer
Copy link
Member

The new vectorised SHA3 code is included in places where it shouldn't, i.e. where no simd256 is available.

For example (why is this included in SHA2 anyway?)

hacl-star/dist/gcc-compatible/Hacl_SHA2_Types.h

Line 38 in 81f0e3b

#include "Hacl_Hash_SHA3_Simd256.h"

hacl-star/dist/gcc-compatible/Hacl_SHA2_Vec128.h

Line 38 in 81f0e3b

#include "Hacl_Hash_SHA3_Simd256.h"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@franziskuskiefer