-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code quality issue in SHA3: useless division #816
Comments
Permanent link for the code mentioned above:
|
Relevant F* code:
The update_multi instantiation for Keccak:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reported by @karthikbhargavan
https://github.com/hacl-star/hacl-star/blob/main/dist/gcc-compatible/Hacl_Hash_SHA3.c#L307 could be 1 instead of a division
The text was updated successfully, but these errors were encountered: