-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LowStar.ConstBuffer, all the way up to the top-level EverCrypt APIs #334
Labels
Comments
Hi Niek, Absolutely agreed, it's just a matter of "upgrading" a bunch of code to use the (somewhat recent) const pointer abstraction that until recently was not available in our modeling of C. I'll leave this issue open so that we can post updates if we upgrade some code to rely on Thanks, Jonathan |
Cool 👍 |
msprotz
changed the title
const-correctness in Evercrypt API
Use LowStar.ConstBuffer, all the way up to the top-level EverCrypt APIs
Nov 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
When using the Evercrypt C API, I noticed that the API could slightly be improved by adding the keyword
const
at various places.For example, the function prototype:
could be adapted to:
Would you agree, or is there a specific reason for not using
const
at those places?Kind regards,
Niek
And last but not least: thank you all for doing this great work and contributing it as open source!
The text was updated successfully, but these errors were encountered: