Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github-handle for Bonnie Wolfe in heart.md #7016

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add github-handle for Bonnie Wolfe in heart.md #7016

merged 1 commit into from
Jun 20, 2024

Conversation

daras-cu
Copy link
Member

Fixes #6939

What changes did you make?

  • Replaced
- name: Bonnie Wolfe

with

- name: Bonnie Wolfe
  github-handle:

in _projects/heart.md

Why did you make the changes (we will use this info to test)?

  • The github-handle variable will later replace the github and picture variables in heart.md to streamline the file

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes

@HackforLABot HackforLABot added this to PR Needs review (Automated Column, do not place items here manually) in Project Board Jun 17, 2024
@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b daras-cu-add-gh-Bonnie-Wolfe-6939 gh-pages
git pull https://github.com/daras-cu/website.git add-gh-Bonnie-Wolfe-6939

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 17, 2024
@ExperimentsInHonesty ExperimentsInHonesty added role: back end and removed role: back end/devOps Tasks for back-end developers labels Jun 18, 2024
@cchrizzle cchrizzle self-assigned this Jun 19, 2024
@cchrizzle cchrizzle self-requested a review June 19, 2024 00:24
@cchrizzle cchrizzle removed their assignment Jun 19, 2024
@cchrizzle
Copy link
Member

Hi @daras-cu, looks good to me!

  1. You have the correct branch linking, branch naming, and linked issue
  2. You correctly added github-handle while also using spaces to indent as the instructions requested
  3. You have an accurate and detailed description of your changes

Great job!

cchrizzle
cchrizzle approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@cchrizzle cchrizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, great job Danielle!

Project Board automation moved this from PR Needs review (Automated Column, do not place items here manually) to test-approved-by-reviewer (Automated Column, do not place items here manually) Jun 19, 2024
@muninnhugin muninnhugin self-requested a review June 19, 2024 14:12
@muninnhugin
Copy link
Member

Review ETA: in 2 days
Availability: Wednesday, Thursday evening

muninnhugin
muninnhugin approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@muninnhugin muninnhugin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daras-cu,

  • branching looks good
  • relevant issue is linked
  • great description of what changes and why, and visual changes
  • code edit is correct and clean
    approving the PR. great work and thanks for contributing!

@zkamenov zkamenov assigned zkamenov and unassigned zkamenov Jun 20, 2024
@jphamtv jphamtv merged commit ff90e15 into hackforla:gh-pages Jun 20, 2024
10 checks passed
@HackforLABot HackforLABot removed this from test-approved-by-reviewer (Automated Column, do not place items here manually) in Project Board Jun 20, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the role: back end/devOps Tasks for back-end developers label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muninnhugin muninnhugin muninnhugin approved these changes

@cchrizzle cchrizzle cchrizzle approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add github-handle for Bonnie Wolfe in heart.md
7 participants
@daras-cu @cchrizzle @muninnhugin @jphamtv @ExperimentsInHonesty @zkamenov @danielle-y