Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linting for python code #407

Open
2 tasks
Aveline-art opened this issue Jun 3, 2023 · 0 comments
Open
2 tasks

Enable linting for python code #407

Aveline-art opened this issue Jun 3, 2023 · 0 comments
Labels
feature: GitHub Actions Pertains to all GHAs (and other GH automations) PBV: dev all issues for engineering roles (devops, backend, frontend, db) ready for milestone role: backend Pertains to backend tasks size: 2pt Can be done in 7-12 hours

Comments

@Aveline-art
Copy link
Member

Overview

As a developer, we should make sure that our code is maintainable. For this ticket, let's start a discussion on whether linting python code is desirable.

Action Items

  • Discuss with the team on whether adding a python linter is desirable.
  • Enable the python linter for super-linter if needed.

Resources/Instructions

Resources

This has never been up for consideration previously, since vscode did not have native support for python linting, meaning that we needed to download them as libraries, which would impact our build size. Now two things have changed:

  1. We are using poetry now, so we can specify optional dev dependencies.
  2. VSCode now has an extension for black and isort. This means that we do not to fangle with any external libraries.
@Aveline-art Aveline-art added role: backend Pertains to backend tasks size: 2pt Can be done in 7-12 hours feature: GitHub Actions Pertains to all GHAs (and other GH automations) ready for milestone labels Jun 3, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the PBV: dev all issues for engineering roles (devops, backend, frontend, db) label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: GitHub Actions Pertains to all GHAs (and other GH automations) PBV: dev all issues for engineering roles (devops, backend, frontend, db) ready for milestone role: backend Pertains to backend tasks size: 2pt Can be done in 7-12 hours
Projects
Status: 📋 Prioritized Backlog
Development

No branches or pull requests

4 participants