Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign-in through 3rd party apps #151

Closed
4 tasks
Aveline-art opened this issue Feb 11, 2022 · 5 comments
Closed
4 tasks

Add sign-in through 3rd party apps #151

Aveline-art opened this issue Feb 11, 2022 · 5 comments
Labels
dependency This item depends on something feature: 1Password PBV: dev all issues for engineering roles (devops, backend, frontend, db) role: backend Pertains to backend tasks size: 13pt+ Must be broken down into smaller issues
Milestone

Comments

@Aveline-art
Copy link
Member

Aveline-art commented Feb 11, 2022

Dependency

  • This will be a post MVP1 task (will depend on MVP launch)

Overview

As a developer we need to meet stakeholder needs. For this issue, we will add sign-in through 3rd party applications to our product.

Action Items

  • Compile the necessary settings and modifications we would need to enable sign-in through these 3rd party websites
    • GitHub
    • Google

Resources/Instructions

Resources
Google: Account linking with Google Sign-In
GitHub: Authorizing OAuth Apps

@Aveline-art Aveline-art added size: 13pt+ Must be broken down into smaller issues role: backend Pertains to backend tasks feature: 1Password labels Feb 11, 2022
@Aveline-art
Copy link
Member Author

Aveline-art commented Feb 11, 2022

Considerations for the team:

  1. I am not sure this issue has a high enough scope to adversely affect other developer issues. On the other hand, websites can change their authorization policy at the drop of the a hat (for example, GitHub only allows PAT tokens for API access as of last year). Therefore, it is my opinion that this issue should only be done as we near MVP.

@sdimran sdimran added the dependency This item depends on something label Feb 23, 2022
@sdimran sdimran added this to the 04 - Project Setup milestone Mar 6, 2022
@sdimran sdimran removed this from the 04 - Project Setup milestone Mar 6, 2022
@sharadgaurav7
Copy link
Member

@Aveline-art , will you please re-write the objective and explain why do we need the 3rd party sign-in, or what is it going to accomplish.
NOT URGENT :)

@Aveline-art
Copy link
Member Author

@sharadgaurav7 @sdimran I just noticed this is marked with 02 milestone, but is explicitly a post MVP issue. Just want to make sure there is not an error.

@kcoronel
Copy link
Member

Test

@ExperimentsInHonesty ExperimentsInHonesty added the PBV: dev all issues for engineering roles (devops, backend, frontend, db) label Jun 12, 2024
@nooriaali9 nooriaali9 removed this from the 02 - Security milestone Jul 16, 2024
@nooriaali9
Copy link
Member

At the moment HackforLA prefers not to use 3rd party apps for sign in. If this changes, we will open a new ticket accordingly.

@nooriaali9 nooriaali9 added this to the 11 - V2 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency This item depends on something feature: 1Password PBV: dev all issues for engineering roles (devops, backend, frontend, db) role: backend Pertains to backend tasks size: 13pt+ Must be broken down into smaller issues
Projects
Status: Done
Development

No branches or pull requests

6 participants