Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRONG RTON number header hex 0x49 #22

Open
SMFDrummer opened this issue Mar 26, 2024 · 2 comments
Open

WRONG RTON number header hex 0x49 #22

SMFDrummer opened this issue Mar 26, 2024 · 2 comments

Comments

@SMFDrummer
Copy link

Please change it to 0x45 instead in CHUNK_TYPE
0x49 is deprecated

@nineteendo
Copy link

Agreed, 0x49 would be varuint64_t (a signed unsigned int64), which doesn't make sense:

Bytecode Type Limitations
0x24 uvarint32_t  0-2147483647
0x25 varint32_t  -2147483648-2147483647
0x28 uvaruint32_t  0-4294967295
0x44 uvarint64_t  0-9223372036854775807
0x45 varint64_t  -9223372036854775808-9223372036854775807
0x48 uvaruint64_t  0-18446744073709551615

@SMFDrummer
Copy link
Author

I am trying to rewrite the RETON project using Kotlin, but besides 0x49, I have also encountered some decoding issues with rton2json. For example, I am unable to correctly transcode and shape data because there are too many types of data. I can provide the source code of the semi-finished Kotlin project. Can you give me some improvement suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants