-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to FontAwesome v5 #9
Comments
Thank you for bringing this up. I will update FontAwesome version shortly. |
Above is a PR based around 2i from the above suggestions. It seems to work fairly well though I haven't been able to check it extensively. Here's a chart based on one of the examples given for the module and the new icon set Generated using:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
Thanks for creating this module, it's really useful and pretty straightforward to use.
One thing I've noticed is that the module currently uses FontAwesome v4.7.0, with the latest version of FA being v5.5.0. It'd be nice to be able to use the latest set of icons and updating the equivalence should be relatively straightforward through the cheatsheet they provide, but the download is now (I believe since 5.0) split into three
.otf
files - "solid", "regular" and "brands". I see there being two ways to deal with this:icon_set
as a string).I am happy to work on a PR for this based on your preference. I think 2i would work best (and might start looking at implementing it), but will defer to your judgement. There may also be some compatibility issues with name changes, but I think it's worth it for the wider set of icons available.
Thanks,
Adam
The text was updated successfully, but these errors were encountered: