-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks of a single colour are not always contiguous #20
Comments
This is the expected result, as the default drawing direction is from bottom left going up, then going right. |
Hi @gyli. Thanks for your package. Those examples do not address the question of keeping colours contiguous. You can consider this a feature request rather than a bug if you like, but I'm saying currently the output doesn't look good. It would look much better if the yellow blocks were contiguous, and I think your code could be fixed to ensure that --- or to give it as another option. |
I'm sorry that I din't get your point of keeping colors contiguous. If you take a look of the similar example in the README page, it is drawing from upper left to bottom right, while it does not avoid yellow blocks being separated, since there's just not enough blocks. https://github.com/gyli/PyWaffle/raw/master/examples/readme/title_and_legend.svg |
That's not necessary. |
OK, that's also what I mean. I think we can do an option allowing this. |
No. That is painted top to bottom on every column. |
The point is never to jump from the top to the bottom, or bottom to top, when you're painting. Lay down squares by snaking back and forth. Look at my first example at the top of this Issue. |
I see. That is a good point! |
@cpbl The feature is added in the latest version 0.6.0. Use parameter block_arranging_style='snake' to enable it. Doc could be found here https://pywaffle.readthedocs.io/en/latest/examples/block_shape_distance_location_and_direction.html#where-to-start-each-category Thanks again for this great idea! |
Nice work, and thank you for this addition and for the project. |
In this example output, the yellow block is split up, unnecessarily:
(from example at https://stackoverflow.com/questions/41400136/how-to-do-waffle-charts-in-python-square-piechart )
Shouldn't the rolling out of blocks go down one column, then up the next, then down the next, and so on, in order to ensure that coloured regions remain contiguous?
The text was updated successfully, but these errors were encountered: