Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font awesome license #19

Closed
toddrme2178 opened this issue Nov 19, 2019 · 2 comments
Closed

Font awesome license #19

toddrme2178 opened this issue Nov 19, 2019 · 2 comments

Comments

@toddrme2178
Copy link
Contributor

I notice that files from the Font Awesome project are being used. The project's license requires attribution. IANAL, and I am not affiliated with that project, but I think there probably needs to be a license file for these files, and this needs to be in the MANIFEST.in file (see #18) so it is included in sdists.

@gyli
Copy link
Owner

gyli commented Nov 19, 2019

Nice catch.

Looks like having MANIFEST.in file is a better solution than specifying package_data in setup.py, since font files are missing in previous .tar.gz file.

I will merge the PR and exclude some docs and examples files, since that's only for ReadTheDocs.

However, to be clear, I don't see the current packing has any issue with Font Awesome license. Font Awesome does require attribution, while it also mentions the font files contain sufficient attribution. The License file of PyWaffle is also packed under dist-info folder.

@gyli
Copy link
Owner

gyli commented Jan 27, 2020

#18

@gyli gyli closed this as completed Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants