Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle search highlight no longer works #88

Closed
folkol opened this issue Oct 31, 2020 · 3 comments
Closed

Toggle search highlight no longer works #88

folkol opened this issue Oct 31, 2020 · 3 comments

Comments

@folkol
Copy link

folkol commented Oct 31, 2020

I use to toggle highlighting of search results back and forth with ESC-u, but since commit 5651293 this no longer works. I would like to understand the rationale behind this change, if this was indeed the intended behaviour. (And if not, consider this a plain old bug report.)

@gwsw
Copy link
Owner

gwsw commented Nov 6, 2020

This was a deliberate change, in response to a request for a way to clear the current search pattern. In retrospect, this feature should probably not have been overloaded onto the ESC-u command. I think it would have been better to leave ESC-u as a toggle and add a new command, perhaps ESC-U, to clear the search pattern. Although I'm somewhat loathe to change the functionality yet again, I'm leaning toward changing ESC-u back to the old behavior as you request and adding a new command to clear the search pattern.

@folkol
Copy link
Author

folkol commented Nov 7, 2020

All right. Thanks for the explanation!

@gwsw
Copy link
Owner

gwsw commented Nov 18, 2020

Fixed in 7b1787e.

@gwsw gwsw closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants