Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s command asks for filename even when it knows it will reject it #50

Closed
subrook opened this issue Mar 3, 2020 · 1 comment
Closed

Comments

@subrook
Copy link

subrook commented Mar 3, 2020

As documented in less 551, the s command "only works if the input is a pipe, not an ordinary file." However, when viewing an ordinary file, typing s gives the prompt log file: and accepts a filename. Only after the filename is entered does it say Input is not a pipe. There is no need to prompt for and allow the user to enter a filename that will only be rejected; whether input is a pipe is known the moment the user presses s.

@gwsw
Copy link
Owner

gwsw commented Mar 5, 2020

Good point. This is fixed in c25faac.

@gwsw gwsw closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants