Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks are not tested during CI #41

Open
bdestombe opened this issue Mar 29, 2022 · 4 comments
Open

Notebooks are not tested during CI #41

bdestombe opened this issue Mar 29, 2022 · 4 comments
Assignees
Labels

Comments

@bdestombe
Copy link
Collaborator

I thought this was the case before. Please have a look at the dtscalibration package if you experience any issues with the implementation.

@OnnoEbbens
Copy link
Collaborator

Yes I removed these tests because they took so long. They are explicitly excluded in ci.yml using py.test ./tests -m "not notebooks".

We can reinstate them but I think we should first improve test efficiency (see also #21).

@bdestombe
Copy link
Collaborator Author

Ah I see. What about the following two options?

  • start two CI pipelines in parallel. One with the notebooks and one with the other tests. While developing only look at the latter one and requiring both for a version bump. I recon it is even worthwhile paying for two CI sessions.
  • Moving the notebook tests to the end of the CI.

@bdestombe
Copy link
Collaborator Author

Onno and I discussed over the phone that I would look into the possibilities of having two parallel pipelines

@dbrakenhoff dbrakenhoff self-assigned this Oct 27, 2022
@dbrakenhoff dbrakenhoff added the enhancement New feature or request label Oct 27, 2022
@ArtesiaWater ArtesiaWater added this to the Release v0.4.0 milestone Oct 28, 2022
@dbrakenhoff dbrakenhoff removed this from the Release v0.4.0 milestone Nov 2, 2022
@OnnoEbbens
Copy link
Collaborator

Solve together with #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants