-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nlmod.to_model_ds() to accept vertex layer_models #298
Comments
Can't you just add the information from your layers to a model-dataset without creating a layer model first:
After which you change top, botm, kh and kv based on your (triwaco) data. The delr and delc attributes represent the properties of the base grid, before refining took place. I think they are ignored by all methods however, so it should be better to remove them. |
Hi Ruben, thanks for your response. Yes, that work-around is similar to the first approach I am describing. But is having a more flexible ds construction routine, which accepts both structured and vertex grids seems preferable to me. If not, the documentation, and maybe even the function name, should reflect that is only supports structured grids. |
Currently
nlmod.to_model_ds()
silently only accept structuredlayer_model
s. Supporting vertex grids is desired for when the constructed layer_model is not from REGIS but self constructed, i.e. interpreted triwaco layers with refined grids.The current way of doing it, following example nb 3 would be to
I would propose the following:
Does this make sense? Which changes would this imply?
Furthermore, the ds_vertex has properties delr and delc that not make sense as it is a vertex grid now. There are some functions that use the delr and delc attributes, such as some reprojecting functions. These functions mostly also work with vertex grid. But shouldn't they produce an error because the delr and delc are invalid.
edit: renamed ds2 to ds_vertex
The text was updated successfully, but these errors were encountered: