Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC_NO_DIRENT_D_TYPE should be defined on Haiku #159

Closed
Begasus opened this issue Sep 24, 2022 · 6 comments
Closed

GHC_NO_DIRENT_D_TYPE should be defined on Haiku #159

Begasus opened this issue Sep 24, 2022 · 6 comments

Comments

@Begasus
Copy link
Contributor

Begasus commented Sep 24, 2022

Describe the bug
Filesystem fails to compile (filesystem/filesystem.hpp) on Haiku because of missing d_type in dirent structure.

Additional context
doxygen/doxygen#9610

@gulrak
Copy link
Owner

gulrak commented Feb 17, 2023

This is a valid solution for the used version ghc::filesystem v1.5.6, but with #142 this is not needed any more, as starting with v1.5.12 the code detects the presence of dirent.d_type automatically at compile time.

@Begasus
Copy link
Contributor Author

Begasus commented Feb 18, 2023

Could still use the detection for Haiku, otherwise I'm getting: error "Operating system currently not supported!":

From: https://github.com/gulrak/filesystem/blob/master/include/ghc/filesystem.hpp#L79

#elif defined(__QNX__)
#define GHC_OS_QNX
+#elif defined(__HAIKU__)
+#define GHC_OS_HAIKU
#else

@Begasus
Copy link
Contributor Author

Begasus commented Feb 18, 2023

Related PR: #163

@Begasus
Copy link
Contributor Author

Begasus commented Feb 18, 2023

This can be closed I think, created a stand-alone package on Haiku with the related PR here, build and install seem OK.
I'm doing a build for catch2 to see if I can run the provided tests here also, thanks so far! :)

@gulrak
Copy link
Owner

gulrak commented Feb 19, 2023

You are right, I will add the detection.

@Begasus
Copy link
Contributor Author

Begasus commented Feb 20, 2023

Upstream PR merged, thanks! 👍

@Begasus Begasus closed this as completed Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants