Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing include <vector> in forward declarations #15

Closed
Mooseart opened this issue May 14, 2019 · 3 comments
Closed

Missing include <vector> in forward declarations #15

Mooseart opened this issue May 14, 2019 · 3 comments
Assignees
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working
Milestone

Comments

@Mooseart
Copy link

Seems like std::vector is being used but not included. This is with forward declaration by including ghc/fs_std_fwd.hpp and happens only on Windows.

Check in ghc/filesystem.hpp:1009

Solved by adding #include just before #endif // GHC_EXPAND_IMPL

@gulrak gulrak self-assigned this May 15, 2019
@gulrak gulrak added the bug Something isn't working label May 15, 2019
@gulrak
Copy link
Owner

gulrak commented May 15, 2019

Indeed, that is missing. In their blog entry to C++17/20 features of VS2019 they saild they rearranged their own headers so they include less, so I guess the error was hidden by former "greediness" of MSVC headers.

@gulrak
Copy link
Owner

gulrak commented May 15, 2019

Fix with 61182d0 on master. Thank you for reporting.

@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label May 15, 2019
@gulrak gulrak added this to the v1.1.6 milestone May 15, 2019
@Mooseart
Copy link
Author

This problem showed up for me when building with 2017 actually. Maybe the tests include vector on a higher level, or they don't use the forward declaration construct?
Either way, I tested with master now and it compiles fine with vs2017 so I think we can close it. Thanks!

@gulrak gulrak modified the milestones: v1.1.6, v1.2.0 May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants