Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Safari, when exiting the search box, the page jumps to the bottom #134

Open
phated opened this issue Apr 7, 2021 · 6 comments
Open

Comments

@phated
Copy link
Member

phated commented Apr 7, 2021

@donghwipark I just noticed this on the deployed website, do you want to try to fix it?

@ghost
Copy link

ghost commented Apr 7, 2021

@phated Sure! Thank you for your support even you are on a busy schedule!

@ghost
Copy link

ghost commented Apr 24, 2021

@phated I tried to define in what situation this bug occurs first.

  1. Case forced to scroll down not occur
    A. When the screen is on top
    - clicking ESC button
    - clicking outbound of the search popup
    B. When initially screen has moved down even 1 pixel
    - clicking ESC button after inputting some text
    - clicking outbound of the search popup after input some text
    C. When initially screen has moved down even 1 pixel
    - clicking ESC button after inputting some text more than 1 and delete till text become one
    - clicking outbound of the search popup after input some text more than 1 and delete till text become one
  2. Case forced to scroll down occurs
    A. When initially screen is moved down even 1 pixel
    - clicking ESC button
    - clicking outbound of the search popup
    B. When initially screen has moved down even 1 pixel
    - clicking ESC button after inputting some text and delete all the text
    - clicking outbound of the search popup after input some text and delete all the text
    C. When initially screen has moved down even 1 pixel
    - clicking ESC button after inputting one length of text(include 1 character)
    - clicking outbound of the search popup after input inputting one length of text(include 1 character)

So in conclusion this bug can define as below
If the input count is 0 or 1 with even 1 pixel scrolling down, the scroll itself goes down to the bottom when you click "ESC" keyborad or click outside the pop-up window by mouse.

@ghost
Copy link

ghost commented May 29, 2021

I shared the situation on discord. Hope I can get the support from the discord
https://discord.com/channels/398180168688074762/584803742801723424

@lex111
Copy link

lex111 commented Jun 1, 2021

@donghwipark actually this has been fixed in subsequent releases, just update the website to the first beta version.

@ghost
Copy link

ghost commented Jun 5, 2021

@lex111 Thank you so much for the notification will try that way.

@ghost
Copy link

ghost commented Aug 22, 2021

I retested below NG cases in the local environment after update the docusaurus from 2.0.0-alpha.70 to 2.0.0-beta.4


Case forced to scroll down occurs
A. When initially screen is moved down even 1 pixel

  • clicking ESC button -> OK
  • clicking outbound of the search popup -> OK
    B. When initially screen has moved down even 1 pixel
  • clicking ESC button after inputting some text and delete all the text -> OK
  • clicking outbound of the search popup after input some text and delete all the text -> OK
  • clicking ESC button after inputting one length of text(include 1 character) -> Ok
  • clicking outbound of the search popup after input inputting one length of text(include 1 character) -> OK

Conclusion
The bug in Safari, which moves to bottom after in such curcimstances written above is not occuring anymore after update to 2.0.0-beta.4 as @lex111 mentioned. Thank you

Concern
The new version of the header is not fixed on the screen. If you want to fix the header on scroll down please let me know @phated. Will commit the code on package.json update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants