Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule numbers #1955

Merged
merged 1 commit into from
May 17, 2017
Merged

Fix rule numbers #1955

merged 1 commit into from
May 17, 2017

Conversation

tamj0rd2
Copy link
Contributor

@tamj0rd2 tamj0rd2 commented May 15, 2017

At the moment, rule numbers are showing as 1, 1, 1... etc

@yocontra
Copy link
Member

@tamj0rd2 Are these not rendering correctly? According to the github markdown spec the # doesn't matter, so using 1 repeatedly is best to ensure they always increment and don't become unordered

@yocontra yocontra closed this May 15, 2017
@yocontra yocontra reopened this May 15, 2017
@phated
Copy link
Member

phated commented May 15, 2017

That's how it's supposed to work but it looks like they change or broke their parser (I'm seeing this problem everywhere someone mentions using 1 repeated). @contra do you think we should merge this or wait to see if github fixes the bug (assuming it's not an intentional change).

@phated
Copy link
Member

phated commented May 15, 2017

It seems that github did change their parser a while back (as per https://github.com/blog/2333-a-formal-spec-for-github-flavored-markdown and https://githubengineering.com/a-formal-spec-for-github-markdown/). @tamj0rd2 Can you open an issue on https://github.com/github/cmark to see if this is a breaking change they intended before we merge this?

@doowb
Copy link
Member

doowb commented May 15, 2017

The issue isn't with the ordered lists, it's with the unordered sublists inside each bullet for the ordered list. The sublists need to have an additional space before their bullets. GitHub was probably more lenient than the common mark spec before and updated that to be more specific.

Fix the sub-lists (after PR comments)
@tamj0rd2
Copy link
Contributor Author

@doowb Thanks for spotting that. I've updated my commit.

@phated phated merged commit d634e95 into gulpjs:master May 17, 2017
@phated
Copy link
Member

phated commented May 17, 2017

Thanks!!

@tamj0rd2 tamj0rd2 deleted the patch-1 branch May 18, 2017 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants