Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flakey tests #89

Closed
phated opened this issue Feb 3, 2017 · 1 comment
Closed

Flakey tests #89

phated opened this issue Feb 3, 2017 · 1 comment
Labels
help wanted
Milestone
6.0

Comments

@phated
Copy link
Member

phated commented Feb 3, 2017

The tests seem to be a bit flakey. Things like globbing order, etc. These issues can probably be cleaned up.
@phated phated modified the milestone: 6.0 Feb 13, 2017
@phated
Copy link
Member Author

phated commented Feb 13, 2017

Anyone want to take a stab at this? I'm pretty sure most of them are due to array sorting and can probably be rewritten to use

expect(arr).toInclude(expected[0]);
expect(arr).toInclude(expected[1]);
expect(arr).toInclude(expected[2]);

@phated phated closed this as completed in dbf1bb0 Feb 14, 2017
phated added a commit that referenced this issue Feb 16, 2017
@phated
Update: Fix flakey tests (closes #89)
748c208
phated added a commit that referenced this issue Feb 16, 2017
@phated
Update: Fix flakey tests (closes #89)
6b29af8
phated added a commit that referenced this issue Feb 16, 2017
@phated
Update: Fix flakey tests (closes #89)
8efc6ab
phated added a commit that referenced this issue Feb 16, 2017
@phated
Update: Fix flakey tests (closes #89)
600b48d
phated added a commit that referenced this issue Feb 20, 2017
@phated
Update: Fix flakey tests (closes #89)
4b411f2
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Fix flakey tests (closes #89)
a048187
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Fix flakey tests (closes #89)
950d45e
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Fix flakey tests (closes #89)
09bdc8e
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Fix flakey tests (closes #89)
8706907
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Fix flakey tests (closes #89)
16feab9
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Fix flakey tests (closes #89)
84a60c0
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Fix flakey tests (closes #89)
878c707
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Fix flakey tests (closes #89)
c238932
phated added a commit that referenced this issue Feb 21, 2017
@phated
Update: Fix flakey tests (closes #89)
fb92691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
1 participant
@phated