Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MenuBar and StatusBar to be adornments #2488

Closed
3 tasks
tig opened this issue Apr 4, 2023 · 3 comments
Closed
3 tasks

Refactor MenuBar and StatusBar to be adornments #2488

tig opened this issue Apr 4, 2023 · 3 comments
Labels
v2 For discussions, issues, etc... relavant for v2
Milestone

Comments

@tig
Copy link
Collaborator

tig commented Apr 4, 2023

This is a sub-issue of:

Todo

  • Reimplemen these views based on Bar. See Create a new Bar view to replace StatusBar (and eventually MenuBar) #3073
  • Remove the dependency between these classes and Toplevel and enable any view to host a menubar or statusbar (or any View).
  • By default Window will have the menubar and statusbar's added to it's Border/Adornment Frame but they will be Visible = false by default. We'll expose helper properties to access them:

win.MenuBar.Visible = true etc...

@tig
Copy link
Collaborator Author

tig commented Jul 11, 2024

Not entirely sure this is needed.

@tig tig modified the milestones: V2 Beta, v2 Release Jul 11, 2024
@BDisp
Copy link
Collaborator

BDisp commented Jul 11, 2024

Not entirely sure this is needed.

I don't think this make senses because any view has adornments and the question must be should MenuBar and StatusBar be created in the parent adornments? Now it's possible to add it anywhere the user want it, right? If affirmative then this can be closed.

@tig
Copy link
Collaborator Author

tig commented Jul 11, 2024

I had two reasons for suggesting this:

  1. Views can't render outside of their Viewport. That's a new LAW for v2. But the same law does not apply to Adornments because they are system managed. Menu, in particular, has the need to render outside of the Viewport because a dropdown may be larger than the view.

  2. The Toplevel code that tries to be "smart" about Menu/Statusbar is clumsy and bug ridden. I was thinking putting them in Padding might enable this to be simplified.

I still think 1) is semi-valid. I don't think 2) is valid anymore.

I'm going to close this for now though as there's not enough justification.

@tig tig closed this as completed Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 For discussions, issues, etc... relavant for v2
Projects
Status: ✅ Done
Status: 📋 Approved - Need Owner
Development

No branches or pull requests

2 participants