Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfect_BP should not have an impact if USE_BRANCH_PREDICTION was set to false #69

Open
FanosLab opened this issue Oct 3, 2023 · 0 comments

Comments

@FanosLab
Copy link

FanosLab commented Oct 3, 2023

Hello,
Another issue in the frontend_c::predict_bpu function is that if BP was disabled but the user sets perfect_BP, it will still act as perfect.
It might be more of a usability than a correctness issue but it sounds more intuitive if BP was disabled to void the effect of the perfect_BP parameter.
In that case, this line of code:

if (*m_simBase->m_knobs->KNOB_USE_BRANCH_PREDICTION) mispredicted = false;

can be replaced by the condition of use_branch_prediction:

if ((*m_simBase->m_knobs->KNOB_USE_BRANCH_PREDICTION) && (*m_simBase->m_knobs->KNOB_PERFECT_BP)) mispredicted = false;

Mohamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant