Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta.json semantic versioning #33

Merged
merged 4 commits into from
Mar 12, 2022
Merged

meta.json semantic versioning #33

merged 4 commits into from
Mar 12, 2022

Conversation

DerZade
Copy link
Member

@DerZade DerZade commented Mar 10, 2022

This PR will fix #32, by introducing semver for the version field within the meta.json.

Fusselwurm
Fusselwurm approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@Fusselwurm Fusselwurm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheWillard TheWillard merged commit 38a5924 into master Mar 12, 2022
@TheWillard TheWillard deleted the meta-json-version branch March 12, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fusselwurm Fusselwurm Fusselwurm approved these changes

@TheWillard TheWillard TheWillard approved these changes

Assignees

@TheWillard TheWillard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version field in meta.json must be a number
3 participants
@DerZade @Fusselwurm @TheWillard