Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shelltracker increasingly broken with time passing #38

Closed
b-mayr-1984 opened this issue Mar 30, 2024 · 2 comments · Fixed by #40
Closed

shelltracker increasingly broken with time passing #38

b-mayr-1984 opened this issue Mar 30, 2024 · 2 comments · Fixed by #40
Assignees
@senshi-x
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@b-mayr-1984
Copy link
Member

b-mayr-1984 commented Mar 30, 2024 •
edited
Loading

With increasing time spent in the mission the shell tracking feature shows to be increasingly broken.
Shells being fired are then not shown in the systemChat anymore and also the map markers are not visible.

Video proof

Most likely cause

GetInMan is described as being Persistent on respawn if assigned where unit was local.
The later is probably not the case, because fn_postInit.sqf#L6 makes sure it is assigned where a Zeus is local, not the artillery players.

Further reading
@b-mayr-1984 b-mayr-1984 added bug Something isn't working help wanted Extra attention is needed labels Mar 30, 2024
@b-mayr-1984
Copy link
Member Author

@senshi-x since this is your baby, do you want to take a look at this, or shall I have a look on how to best fix this?

@senshi-x senshi-x self-assigned this Mar 30, 2024
@senshi-x
Copy link
Contributor

Will take a look.

senshi-x added a commit to senshi-x/Shoot_and_Scoot.Tanoa that referenced this issue Mar 31, 2024
@senshi-x
ShellTracker Update
fc451c1 
- Added re-init of GetInMan EH on respawn. Fixes gruppe-adler#38
- Added unit-specific re-init handling instead of allPlayers. Improves performance load on respawn/JIP.
@senshi-x senshi-x mentioned this issue Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senshi-x senshi-x

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ShellTracker Update senshi-x/Shoot_and_Scoot.Tanoa
2 participants
@senshi-x @b-mayr-1984