Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-loader: Expose method options #2711

Merged
merged 16 commits into from
Apr 9, 2024
Merged

Conversation

n0v1
Copy link
Contributor

@n0v1 n0v1 commented Apr 8, 2024

This PR adds support for MethodOptions to proto-loader.

It is a continuation of #2230 (originally written by @hiepthai) which tries to address the comments of @murgatroid99.

Copy link

linux-foundation-easycla bot commented Apr 8, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. This addresses a lot of the concerns I had with the previous attempt. You will need to fix the CLA issues before I can accept it.

Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this up. It looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants