stub: Enable rejected execution exception by default on ThreadlessExecutor #10555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-rejected-execution-exception
ejona86
approved these changes
Sep 12, 2023
|
fixes #10548 |
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Sep 25, 2023
…essExecutor shutdown (grpc#10555)" This reverts commit 5f480de. We're seeing it thrown in (b/301552213): ``` java.util.concurrent.RejectedExecutionException at io.grpc.stub.ClientCalls$ThreadlessExecutor.execute(ClientCalls.java:761) at io.grpc.internal.RetriableStream$Sublistener.closed(RetriableStream.java:954) at io.grpc.internal.ForwardingClientStreamListener.closed(ForwardingClientStreamListener.java:34) at io.grpc.internal.InternalSubchannel$CallTracingTransport$1$1.closed(InternalSubchannel.java:691) at io.grpc.internal.DelayedStream$DelayedStreamListener$4.run(DelayedStream.java:510) at io.grpc.internal.DelayedStream$DelayedStreamListener.delayOrExecute(DelayedStream.java:462) at io.grpc.internal.DelayedStream$DelayedStreamListener.closed(DelayedStream.java:507) at io.grpc.internal.AbstractClientStream$TransportState.closeListener(AbstractClientStream.java:458) at io.grpc.internal.AbstractClientStream$TransportState.-$$Nest$mcloseListener(AbstractClientStream.java) at io.grpc.internal.AbstractClientStream$TransportState$1.run(AbstractClientStream.java:441) at io.grpc.internal.AbstractClientStream$TransportState.deframerClosed(AbstractClientStream.java:278) at io.grpc.okhttp.OkHttpClientStream$TransportState.deframerClosed(OkHttpClientStream.java:297) at io.grpc.internal.MessageDeframer.close(MessageDeframer.java:234) at io.grpc.internal.MessageDeframer.closeWhenComplete(MessageDeframer.java:192) at io.grpc.internal.AbstractStream$TransportState.closeDeframer(AbstractStream.java:201) at io.grpc.internal.AbstractClientStream$TransportState.transportReportStatus(AbstractClientStream.java:444) at io.grpc.okhttp.OkHttpClientTransport.startGoAway(OkHttpClientTransport.java:899) at io.grpc.okhttp.OkHttpClientTransport.-$$Nest$mstartGoAway(OkHttpClientTransport.java) at io.grpc.okhttp.OkHttpClientTransport$ClientFrameHandler.run(OkHttpClientTransport.java:1123) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644) at java.lang.Thread.run(Thread.java:1012) ```
ejona86
added a commit
that referenced
this pull request
Sep 25, 2023
…essExecutor shutdown (#10555)" This reverts commit 5f480de. We're seeing it thrown in (b/301552213): ``` java.util.concurrent.RejectedExecutionException at io.grpc.stub.ClientCalls$ThreadlessExecutor.execute(ClientCalls.java:761) at io.grpc.internal.RetriableStream$Sublistener.closed(RetriableStream.java:954) at io.grpc.internal.ForwardingClientStreamListener.closed(ForwardingClientStreamListener.java:34) at io.grpc.internal.InternalSubchannel$CallTracingTransport$1$1.closed(InternalSubchannel.java:691) at io.grpc.internal.DelayedStream$DelayedStreamListener$4.run(DelayedStream.java:510) at io.grpc.internal.DelayedStream$DelayedStreamListener.delayOrExecute(DelayedStream.java:462) at io.grpc.internal.DelayedStream$DelayedStreamListener.closed(DelayedStream.java:507) at io.grpc.internal.AbstractClientStream$TransportState.closeListener(AbstractClientStream.java:458) at io.grpc.internal.AbstractClientStream$TransportState.-$$Nest$mcloseListener(AbstractClientStream.java) at io.grpc.internal.AbstractClientStream$TransportState$1.run(AbstractClientStream.java:441) at io.grpc.internal.AbstractClientStream$TransportState.deframerClosed(AbstractClientStream.java:278) at io.grpc.okhttp.OkHttpClientStream$TransportState.deframerClosed(OkHttpClientStream.java:297) at io.grpc.internal.MessageDeframer.close(MessageDeframer.java:234) at io.grpc.internal.MessageDeframer.closeWhenComplete(MessageDeframer.java:192) at io.grpc.internal.AbstractStream$TransportState.closeDeframer(AbstractStream.java:201) at io.grpc.internal.AbstractClientStream$TransportState.transportReportStatus(AbstractClientStream.java:444) at io.grpc.okhttp.OkHttpClientTransport.startGoAway(OkHttpClientTransport.java:899) at io.grpc.okhttp.OkHttpClientTransport.-$$Nest$mstartGoAway(OkHttpClientTransport.java) at io.grpc.okhttp.OkHttpClientTransport$ClientFrameHandler.run(OkHttpClientTransport.java:1123) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644) at java.lang.Thread.run(Thread.java:1012) ```
DNVindhya
pushed a commit
to DNVindhya/grpc-java
that referenced
this pull request
Oct 5, 2023
DNVindhya
pushed a commit
to DNVindhya/grpc-java
that referenced
this pull request
Oct 5, 2023
…essExecutor shutdown (grpc#10555)" This reverts commit 5f480de. We're seeing it thrown in (b/301552213): ``` java.util.concurrent.RejectedExecutionException at io.grpc.stub.ClientCalls$ThreadlessExecutor.execute(ClientCalls.java:761) at io.grpc.internal.RetriableStream$Sublistener.closed(RetriableStream.java:954) at io.grpc.internal.ForwardingClientStreamListener.closed(ForwardingClientStreamListener.java:34) at io.grpc.internal.InternalSubchannel$CallTracingTransport$1$1.closed(InternalSubchannel.java:691) at io.grpc.internal.DelayedStream$DelayedStreamListener$4.run(DelayedStream.java:510) at io.grpc.internal.DelayedStream$DelayedStreamListener.delayOrExecute(DelayedStream.java:462) at io.grpc.internal.DelayedStream$DelayedStreamListener.closed(DelayedStream.java:507) at io.grpc.internal.AbstractClientStream$TransportState.closeListener(AbstractClientStream.java:458) at io.grpc.internal.AbstractClientStream$TransportState.-$$Nest$mcloseListener(AbstractClientStream.java) at io.grpc.internal.AbstractClientStream$TransportState$1.run(AbstractClientStream.java:441) at io.grpc.internal.AbstractClientStream$TransportState.deframerClosed(AbstractClientStream.java:278) at io.grpc.okhttp.OkHttpClientStream$TransportState.deframerClosed(OkHttpClientStream.java:297) at io.grpc.internal.MessageDeframer.close(MessageDeframer.java:234) at io.grpc.internal.MessageDeframer.closeWhenComplete(MessageDeframer.java:192) at io.grpc.internal.AbstractStream$TransportState.closeDeframer(AbstractStream.java:201) at io.grpc.internal.AbstractClientStream$TransportState.transportReportStatus(AbstractClientStream.java:444) at io.grpc.okhttp.OkHttpClientTransport.startGoAway(OkHttpClientTransport.java:899) at io.grpc.okhttp.OkHttpClientTransport.-$$Nest$mstartGoAway(OkHttpClientTransport.java) at io.grpc.okhttp.OkHttpClientTransport$ClientFrameHandler.run(OkHttpClientTransport.java:1123) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644) at java.lang.Thread.run(Thread.java:1012) ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran global presubmit on cl/563630388 and it looks fine.