Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for dependencies of grpc package #7690

Closed
dfawley opened this issue Oct 1, 2024 · 0 comments · Fixed by #7766
Closed

Add a test for dependencies of grpc package #7690

dfawley opened this issue Oct 1, 2024 · 0 comments · Fixed by #7766
Assignees
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Type: Testing

Comments

@dfawley
Copy link
Member

dfawley commented Oct 1, 2024

We should add a test in vet.sh to confirm that the dependencies of grpc don't change without our noticing (i.e. vet should fail if they don't match the current list).

go list can pretty easily show dependencies. We should only be checking our direct dependencies and not our transitive dependencies, since we have no control over the transitive ones. We should check the grpc package, the xds package, and any other important packages that are not imported by either of those directly.

@dfawley dfawley added Type: Testing Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. labels Oct 1, 2024
@dfawley dfawley self-assigned this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Type: Testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant