Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "unix" scheme in new resolver/balancer API style #2806

Closed
dfawley opened this issue May 9, 2019 · 1 comment · Fixed by #3890
Closed

Support "unix" scheme in new resolver/balancer API style #2806

dfawley opened this issue May 9, 2019 · 1 comment · Fixed by #3890
Assignees
Labels
P2 Type: Feature New features or improvements in behavior

Comments

@dfawley
Copy link
Member

dfawley commented May 9, 2019

No description provided.

@dfawley dfawley added P2 Type: Feature New features or improvements in behavior labels May 9, 2019
@stale stale bot added the stale label Sep 6, 2019
@dfawley dfawley removed the stale label Sep 6, 2019
@grpc grpc deleted a comment from stale bot Aug 17, 2020
@menghanl
Copy link
Contributor

What's needed:

  1. A unix scheme resolver
    • For "unix:https:///a", the target parser today split it into "unix", "", "a". The resolver needs to handle it, to create connection to "/a" (add a leading slash)
  2. A way to set the dialer
    • Option-1: attach an attribute to the address to specify network_type

Note with the two things above, we would only support unix:https://absolute_path, but not unix:path. Supporting the latter would need change to the target parser, and is a move invasive behavior change (for users assuming a:b picks passthrough).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants