Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Mocking of time dependent tests #352

Open
yashrsharma44 opened this issue Oct 3, 2020 · 1 comment
Open

Introduce Mocking of time dependent tests #352

yashrsharma44 opened this issue Oct 3, 2020 · 1 comment

Comments

@yashrsharma44
Copy link
Collaborator

Currently, some tests such as retry logic use real-time based tests, in which the tests pass/fails, depending on the time taken by the local computer to run that logic, and then check if the time-bound is valid or not. However, on configuring the tests on Github Actions, it is seen that the tests take much longer to execute which creates unnecessary long time to execute, resulting in some tests failing due to the machine taking a long time to execute.

A Solution would be to mock the time clock used in the tests with a mocked time clock, which would make sure that the tests don't fail due to the differences in time taken for execution.

@aboryslawski
Copy link
Contributor

Do you have any specific tests in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants