Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using gorelease (https://godoc.org/golang.org/x/exp/cmd/gorelease) #344

Open
bwplotka opened this issue Oct 2, 2020 · 4 comments
Open
Labels

Comments

@bwplotka
Copy link
Collaborator

bwplotka commented Oct 2, 2020

Pulled from #275 for visibility.

@bwplotka bwplotka added the v2 label Oct 2, 2020
@drewwells
Copy link
Contributor

This is a nifty tool. Can you elaborate on expected features?

gorelease -base=v1 tag -version=???

@bwplotka
Copy link
Collaborator Author

Maybe @johanbrandhorst has ideas? I never used gorelease and also we don't build binaries in this project, so what we can leverage? (:

@johanbrandhorst
Copy link
Collaborator

gorelease is different from goreleaser, which builds binaries. gorelease maintains a compatibility promise. We use it in the grpc-gateway, and we could use it here too.

@drewwells
Copy link
Contributor

drewwells commented Jan 20, 2021

I could see a few uses for this:

  • Evaluate compliance with v1 (is not required but is helpful for documentation)
  • Evaluate each new PR in v2 against v2 to determine if API promises were broken grpc-gateway does this

I'm guessing that the latter is the desired use of this tool. Since v2 is still undergoing API changes, we can't enforce this as a build check. So is the intention to add this as a new github action workflow that will get marked required after the API is settled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants