Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Chrome support #7

Open
Poilaucul opened this issue Oct 18, 2018 · 4 comments
Open

[REQUEST] Chrome support #7

Poilaucul opened this issue Oct 18, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@Poilaucul
Copy link

Hello,

Chrome support possible?

@grmat grmat added the enhancement New feature or request label Oct 21, 2018
@grmat
Copy link
Owner

grmat commented Oct 21, 2018

Hi,

I haven't developed for Chrome yet, but I'm not rejecting the request. I might have a look how much effort it is when I've got some spare time, but don't hold your breath 😉

@pilaco
Copy link

pilaco commented Feb 3, 2020

Any news?

@grmat
Copy link
Owner

grmat commented Feb 3, 2020

No

@mjurczik
Copy link

Hello,

i ported the current version to chrome. You can find the changes here.

Things I've done(see https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Chrome_incompatibilities for differences between ff and chrome):

  • Converting .svg icons to png b/c chrome doesn't support svg, changing paths in manifest.json
  • background.js: renaming all browser namespace occurrences to chrome
  • play.js: also renaming namespace to chrome, removing the promise handling, adding callback which chrome needs. Therefore error handling is done in the onGot method.

In this state the addon could be used in ff aswell, but some warnings will be thrown by firefox due to unknown manifest keys(don't recommend).

Possible solutions to merge both addons:

  • check in which browser the addon is executed, use the correct namespace
    OR
  • create CI/CD job which refactors the current code and "builds" a chrome version
    OR
  • have both versions parallel in one repo, bugfixes/features have to be done in both

Side note:
To publish an addon to chrome store you need a developer account which costs 5$.

Conclusion:

I'm not going to "port" future releases. I don't like Chrome. Just wanted to show how it is done, maybe somebody wants to contribute. I also dislike to have 2 different version just because browser manufactures are unwilling to implement one standard(see here and here). Also I'm not willing to pay 5$ ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants