Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discriminator applies sum-pooling *after* ReLU at the end #47

Open
RohitSaha opened this issue May 21, 2020 · 3 comments
Open

Discriminator applies sum-pooling *after* ReLU at the end #47

RohitSaha opened this issue May 21, 2020 · 3 comments

Comments

@RohitSaha
Copy link

The sequence of operations need to be reversed on line 256 of network.py. According to the paper, "Downsampling is performed via average pooling. Then, after applying ReLU activation function to the output tensor, we perform sum-pooling over spatial dimensions."

However, according to the code, sum-pooling is first applied followed by ReLU.

@mrgloom
Copy link

mrgloom commented Jun 17, 2020

@Jarvisss
Copy link

Jarvisss commented Aug 17, 2020

@RohitSaha Also notice in paper Sec.3.4, "To obtain the vectorized outputs in both networks, we perform global sum pooling over spatial dimensions followed by ReLU." seems the two statements in paper conflict.

@Jarvisss
Copy link

For me, another question is, is in the code, the pooling is implemented as follow:
self.pooling = nn.AdaptiveMaxPool2d((1, 1)) , is this the same as "sum-pooling" according to the paper?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants