✨ Expose better errors #321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much! Will review later today |
aexol
reviewed
Jul 13, 2022
| @@ -65,21 +65,35 @@ export type OperationOptions = { | |||
|
|
|||
| export type ScalarCoder = Record<string, (s: unknown) => string>; | |||
|
|
|||
| import { GraphQLError, type GraphQLErrorOptions } from 'graphql'; // keep | |||
There was a problem hiding this comment.
Shouldn't we copy those from 'graphql` ? Right now it will need 'graphql' as a dep
There was a problem hiding this comment.
Pros:
- No external dependencies
- Backports the feature to users of graphql@<=15
Cons:
- Feels flaky
- We will need to bundle a lot of things
Alternative: create a lite version of GraphQLError, but it will be incompatible with its graphql-js#GraphQLError counterpart, and we will need to export it as GraphQLError which is a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQL v16.5.0 has introduced new types that we can leverage to expose better errors.
Features introduced by this PR:
ZeusError, replacing the confusingGraphQLErrorGraphQLErrorsZeusErroris fully serializable and parse-able (new ZeusError(JSON.parse(JSON.serialize(zeusError)))works great if you don't care about stack-traces)Breaking changes: none
I also refreshed the examples.