New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHook Reply doesnt work with Fastify Adapter as { content-type': 'application/json'} is missing from headers . #540

Closed

scyther opened this issue Mar 8, 2024 · 1 comment · Fixed by #541

Labels

scyther commented Mar 8, 2024

/** fastify web framework */
const fastify: FrameworkAdapter = (req, reply) => ({
    update: Promise.resolve(req.body),
    header: req.headers[SECRET_HEADER_LOWERCASE],
    end: () => reply.status(200).send(),
    respond: (json) => reply.send(json),
    unauthorized: () => reply.code(401).send(WRONG_TOKEN_ERROR),
});

instead of respond: (json) => reply.send(json) it should be respond: (json) => reply.headers({'content-type': 'application/json'}).send(json)

The text was updated successfully, but these errors were encountered:

KnorpelSenf mentioned this issue

fix: set content-type for fastify #541

Merged

Member

KnorpelSenf commented Mar 8, 2024

I'm surprised that nobody discovered this earlier, thanks for reporting. Could you review #541 and approve it if it is correct?

KnorpelSenf added the bug label

KnorpelSenf closed this as completed in #541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment